soc/intel_adsp: Correct linker syntax for ancient binutils #38374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Older binutils, like the (nine-year-old!) 2.23 version that powers many Cadence XCC toolchains, happen not to support the "~" operator to perform bitwise negation. And they generate an absolutely hilarious series of inscrutable error messages when they try to tell you this fairly simple fact. Just fold it into the constant. Signed-off-by: Andy Ross <andrew.j.ross@intel.com>
andyross
force-pushed
the
xcc-bitsilly
branch
from
19d5448
to
df415ff
Compare
dcpleung
approved these changes
Sep 7, 2021
|
Tentatively Fixes: #38349 |
Cadence XCC is based off of a very old 4.2 gcc compiler, which didn't perfectly support C99 "inline" semantics with respect to cross-translation-unit inline linkage (which Zephyr does not use, our inlines are static only) and declaration order. Fix the one spot where we were calling an inline before its ALWAYS_INLINE definition, and add a flag to suppress the warning so CI's trying to build with XCC and -Werror don't flip out. Signed-off-by: Andy Ross <andrew.j.ross@intel.com>
|
Add a patch to suppress some warnings under XCC that were unmasked. |
nashif
approved these changes
Sep 8, 2021
|
Thanks @andyross , SOF build works again! |
kv2019i
added a commit
to kv2019i/sof
that referenced
this pull request
Sep 8, 2021
The regression in Zephyr mainline is fixed with zephyrproject-rtos/zephyr#38374 , so the XCC build can be renabled for cAVS targets. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
lgirdwood
pushed a commit
to thesofproject/sof
that referenced
this pull request
Sep 8, 2021
The regression in Zephyr mainline is fixed with zephyrproject-rtos/zephyr#38374 , so the XCC build can be renabled for cAVS targets. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older binutils, like the (nine-year-old!) 2.23 version that powers
many Cadence XCC toolchains, happen not to support the "~" operator to
perform bitwise negation. And they generate an absolutely hilarious
series of inscrutable error messages when they try to tell you this
fairly simple fact.
Just fold it into the constant.
Signed-off-by: Andy Ross andrew.j.ross@intel.com